Additional thread synchronization in the AggregateProcessor to prevent orphaned aggregate groups#6439
Merged
dlvenable merged 1 commit intoJan 28, 2026
Conversation
…revent duplicate or orphaned aggregate groups. Signed-off-by: David Venable <dlv@amazon.com>
dlvenable
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
graytaylor0
approved these changes
Jan 28, 2026
dinujoh
approved these changes
Jan 28, 2026
simonelbaz
pushed a commit
to simonelbaz/data-prepper
that referenced
this pull request
Jan 31, 2026
…revent duplicate or orphaned aggregate groups. (opensearch-project#6439) Signed-off-by: David Venable <dlv@amazon.com> Signed-off-by: Simon ELBAZ <elbazsimon9@gmail.com>
simonelbaz
pushed a commit
to simonelbaz/data-prepper
that referenced
this pull request
Jan 31, 2026
…revent duplicate or orphaned aggregate groups. (opensearch-project#6439) Signed-off-by: David Venable <dlv@amazon.com>
simonelbaz
pushed a commit
to simonelbaz/data-prepper
that referenced
this pull request
Jan 31, 2026
…revent duplicate or orphaned aggregate groups. (opensearch-project#6439) Signed-off-by: David Venable <dlv@amazon.com>
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.13 2.13
# Navigate to the new working tree
cd .worktrees/backport-2.13
# Create a new branch
git switch --create backport/backport-6439-to-2.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 72ad01221742716c4c1de8ea0b095cf0cf3dd682
# Push it to GitHub
git push --set-upstream origin backport/backport-6439-to-2.13
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.13Then, create a pull request where the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We are seeing cases where aggregations are not acknowledging completion. From investigation, I can see that there are places where we can have orphaned aggregate groups. Basically, some code paths can create two aggregate groups and only one remains in the map.
This PR adds tight synchronization on each AggregateProcessor to prevent these possible duplicates or orphans.
We may be able to improve this later. But, for now, this should fix the current issue.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.